Skip to content

Fix exposed overridables test #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 147 commits into
base: share-filter
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

ScriptedAlchemy and others added 30 commits November 17, 2024 15:21
# Conflicts:
#	pnpm-lock.yaml
# Conflicts:
#	pnpm-lock.yaml
# Conflicts:
#	pnpm-lock.yaml
# Conflicts:
#	pnpm-lock.yaml
# Conflicts:
#	pnpm-lock.yaml
ScriptedAlchemy and others added 28 commits May 21, 2025 02:42
…ation Next.js apps

- Add Cypress e2e test infrastructure for apps 4000 & 4001
- Implement automatic server startup and cleanup in test:e2e target
- Add Module Federation specific test coverage for remote components
- Configure proper timeouts for server readiness (25s startup, 30s connectivity)
- Add enhanced logging with emojis for test lifecycle visibility
- Include kill-app script for manual port cleanup
- Achieve 100% test success rate (19/19 tests passing)

Tests cover:
- Homepage functionality and navigation
- Module Federation infrastructure validation
- Remote app connectivity and error handling
- Federated component loading scenarios
- Automatic server lifecycle management

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Fix nextjs-mf test import errors for share-internals-client functions
- Update enhanced tests for nodeModulesReconstructedLookup per-share configuration
- Update snapshot tests for React 19.1.0 compatibility
- Remove pnpm overrides for React/Next.js versions to resolve conflicts
- Remove webpack/react peer dependencies from nextjs-mf package
- Add webpack as direct dependency to Next.js applications
- Update data-prefetch and bridge-react tests for React 19 compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Fixes several test failures in the enhanced package:

1. ConsumeSharedPlugin layer filtering: Updated from `layer` to
   `issuerLayer` for proper layer-aware sharing
2. HoistContainerReferencesPlugin: Rewrote test to work with new
   architecture using file-based module detection
3. ProvideSharedPlugin version resolution: Added dependency fallback
   logic to resolve versions from parent package.json
4. ConsumeSharedPlugin node reconstruction: Fixed parameter passing
   for reconstructed lookups

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: 24267f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from app-router-share-filter to share-filter July 8, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant